Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete the webui job if the engine job is not deleted #62

Closed
josteinaj opened this issue Feb 4, 2016 · 3 comments · Fixed by #78
Closed

Don't delete the webui job if the engine job is not deleted #62

josteinaj opened this issue Feb 4, 2016 · 3 comments · Fixed by #78
Assignees

Comments

@josteinaj
Copy link
Member

If you try to delete a job that also exists in the engine, but the DELETE request to the engine fails, then don't delete the webui job. Rather display an error along the lines of "not able to delete job from the Pipeline 2 engine".

@bertfrees
Copy link
Member

@josteinaj Also if a job is running, the engine can't delete the job (daisy/pipeline-framework#76), so it also better to not remove it from the user interface, right? Does your commit also fix that?

@josteinaj
Copy link
Member Author

Yes the commit should fix that as well, although I haven't tested it. If the DELETE request to the engine was successful, the deletion is assumed to be successful.

@bertfrees
Copy link
Member

OK good. Then let's hope the engine doesn't accept the DELETE request if the job is running :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants