Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how reports are included in the job results page #60

Open
josteinaj opened this issue Feb 4, 2016 · 1 comment
Open

Improve how reports are included in the job results page #60

josteinaj opened this issue Feb 4, 2016 · 1 comment

Comments

@josteinaj
Copy link
Member

josteinaj commented Feb 4, 2016

  • Try using iframes to isolate the CSS and be able to include the entire <html> document instead of stripping out the <body>.
  • Ensure that the base of the document in the iframe is so that relative links in the report, such as images, css imports, fonts, and links work. Maybe inject a <base> element at the top of the document in the iframe if needed.
  • Have a quick look at whether it would be possible (in a consistent way) to create relative links from the report to other result ports/options.
@bertfrees
Copy link
Member

OK makes a lot of sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants