Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate jobs created #232

Open
marisademeglio opened this issue Jun 7, 2024 · 5 comments
Open

duplicate jobs created #232

marisademeglio opened this issue Jun 7, 2024 · 5 comments

Comments

@marisademeglio
Copy link
Member

marisademeglio commented Jun 7, 2024

Testing feedback from @rachanasinghg for 1.4.0-beta

For image DP_DuplicateJobsCreated , i find when i try to run a particular job, similar jobs are being run in the end, as you can see in the image attached, while running first job named D2_Katie ,6th job is created on its own, i deleted the others with similar name. There were more jobs created whenever I was editing the job.

DP_DuplicateJobsCreated

@marisademeglio
Copy link
Member Author

@rachanasinghg can you give me a recipe to reproduce this in the simplest way possible? E.g. no other jobs going on, and can you email me the source material used? The job log and settings.json file would also be useful to see (settings.json is in C:\Users\<username>\AppData\Roaming\pipeline-ui\settings.json). Email me the files or if you post anything here, make sure to remove sensitive info e.g. TTS API keys.

@rachanasinghg
Copy link
Collaborator

Hi Marisa,

Have mailed you the steps and files as requested.
Thanks.

Regards
Rachana

@marisademeglio
Copy link
Member Author

The issue here is that the user did not expect "Edit job" to create a new tab but to edit the job in an existing tab. But this behavior is intentional and was requested by #130. We may however consider making a note on the "Edit job" button or in the documentation that it will create a new tab.

@NPavie
Copy link
Collaborator

NPavie commented Jun 10, 2024

@rachanasinghg @marisademeglio note that the original behaviour (edit in place instead of in a new tab) is still possible :
We added an "Editing jobs in new tabs" setting to control this in the Settings window under the "Behavior" section.

@rachanasinghg
Copy link
Collaborator

Thanks @NPavie , it works now.
Nice to know about this checkbox.
One more suggestion, it will be good not to open multiple tabs as per Edit job button clicks, 1 or 2 tabs are still ok, so many will surely create confusion.
Also, if 2 duplicate tabs are created then they should be side by side, in the first image which i shared named Duplicate job Created, the first job duplicate is created at 6th job position (when user presses the Edit button).
It will be great if that can be handled.
Thank you.

@marisademeglio marisademeglio modified the milestone: 1.4 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants