Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish nightly builds #142

Open
bertfrees opened this issue May 22, 2023 · 4 comments
Open

Publish nightly builds #142

bertfrees opened this issue May 22, 2023 · 4 comments
Labels
ci continuous integration

Comments

@bertfrees
Copy link
Member

bertfrees commented May 22, 2023

We could modify the Github workflow to build on every commit and attach the build artifacts to a special release tagged "snapshot". But first we need to get the build working again.

@GeorgeKerscher
Copy link

GeorgeKerscher commented May 22, 2023 via email

@bertfrees
Copy link
Member Author

bertfrees commented May 23, 2023

Yes, it seems to be much like Thorium.

Link to Github releases page: https://github.com/edrlab/thorium-reader/releases

@danielweck
Copy link
Member

Hello, Thorium's continuous release technique is quite rudimentary / wonky, because although it is now powered by a GitHub Actions Workflow, it was originally implemented for Travis and AppVeyor. You know the adage "if it ain't broke ... don't fix it" (wink)

Basically, an external Javascript invokes GitHub's HTTP REST APIs via the Octokit NodeJS lib (see links below). The difficult part was to remove existing release tags and associated uploaded assets. This phase sometimes still fails (not sure why), resulting in dangling release drafts in the GitHub page (thankfully, only admins/developers see this, not end-users).

With our technique, old builds are replaced, we do not provide a build archive. Basically, we only provide a build of the latest HEAD of the develop branch. This may not be desirable in your case (i.e. you might want to be able to test previous automated nightly builds, to match an end-user experience).

Links:

https://github.com/edrlab/thorium-reader/blob/4e62aeca5a231a68b7940d17b62a0c656eeabf52/.github/workflows/main.yml#L114
==>
https://github.com/edrlab/thorium-reader/blob/develop/scripts/release-github.js

@bertfrees
Copy link
Member Author

bertfrees commented May 23, 2023

@danielweck Thanks. This is exactly what I had in mind, and what we also do for Liblouis. (We don't remove tags though.) I'm not interested in going back to older builds.

@marisademeglio marisademeglio added the ci continuous integration label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci continuous integration
Projects
None yet
Development

No branches or pull requests

4 participants