P256.sol: support precompile as primary, use solidity as fallback #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalinbhardwaj
force-pushed
the
nibnalin/support-precompile
branch
from
bdb0c18 to
4ad990d
Compare
dcposch
reviewed
May 19, 2024
src/P256.sol
Outdated
|
|
||
| return abi.decode(ret, (uint256)) == 1; | ||
| (bool success, bytes memory ret) = PRECOMPILE.staticcall(args); | ||
| if (success && ret.length > 0) return abi.decode(ret, (uint256)) == 1; |
There was a problem hiding this comment.
This check will pass if the precompile is not deployed on a given chain...
Just confirmed that an undeployed contract (codesize 0) will return success=true, ret=empty array. And codesize will return 0 for the precompile address whether you're on a 7212 chain or not.
I think RIP-7212 is flawed and needs to be fixed
nalinbhardwaj
force-pushed
the
nibnalin/support-precompile
branch
from
e671bd2 to
fd46bca
Compare
nalinbhardwaj
added a commit
that referenced
this pull request
May 19, 2024
* P256.sol: support precompile as primary, use solidity as fallback * P256.sol: add fallback test
0xBigBoss
pushed a commit
to 0xBigBoss/p256-verifier
that referenced
this pull request
Jul 11, 2024
…imo-eth#43) * P256.sol: support precompile as primary, use solidity as fallback * P256.sol: add fallback test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
untested, need to figure out a way to test it against a deployment that is finalized before merging -- using foundry with Polygon Amoy testnet fork-url doesn't seem to work.