Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opinion on allowing unordered ad sequences on Ad Pods for resolveAll method #360

Open
ZacharieTFR opened this issue Jun 8, 2020 · 0 comments
Assignees

Comments

@ZacharieTFR
Copy link
Contributor

As mentionned in #359 (comment) for a Ad Pod that have multiple Ad elements with unique sequence attributes inside a VAST but are not in ascending order the resolveAll() method will return only the first Ad element.

Meaning that resolveAll() return the first Ad element found in VAST for any VAST that contain an Ad Pod with:

  • sorted in descending order (e.g for Ad sequence3>Ad sequence2>Ad sequence1 it return Ad sequence3)
  • non sorted Ad elements (e.g for Ad sequence1>Ad sequence3>Ad sequence2 >it return Ad sequence1)

Note: When the VAST is parsed using basic methods (vastClient.get, vastParser.parseVAST, vastParser.getAndParseVAST etc..) all VAST elements are correctly parsed and returned inside a JSON object. If an Ad pod is unordered the parsing result with return parsed elements in the same order.

Please comment this issue if you have an express need for it. If so we will add the feature. In the meanwhile feel free to contribute by creating a pull request to add the support of this feature! 💪

@ZacharieTFR ZacharieTFR self-assigned this Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant