Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BASIS v1.15 causes class-memaccess warnings #219

Open
oznogon opened this issue Jan 21, 2023 · 0 comments
Open

BASIS v1.15 causes class-memaccess warnings #219

oznogon opened this issue Jan 21, 2023 · 0 comments

Comments

@oznogon
Copy link
Contributor

oznogon commented Jan 21, 2023

ubuntu-latest CI flags a warning for basisu/BASIS Universal:

/home/runner/work/SeriousProton/build/_deps/basis-src/encoder/../transcoder/basisu_containers.h:323:19: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘class basisu::vec<4, float>’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  323 |             memcpy(m_p, other.m_p, other.m_size * sizeof(T));
      |             ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This doesn't impede other builds.

Our usage appears to be based on v1.15-update2. BASIS v1.16.3 changes this behavior (BinomialLLC/basis_universal@7a2094b), but I don't know if that resolves this warning.

v1.16.3 causes several breaking changes: mosra/magnum-plugins#119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant