Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussions about proxy-polyfill #30

Open
dai-shi opened this issue Jun 30, 2019 · 1 comment
Open

Discussions about proxy-polyfill #30

dai-shi opened this issue Jun 30, 2019 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@dai-shi
Copy link
Owner

dai-shi commented Jun 30, 2019

From Twitter: https://twitter.com/dai_shi/status/1145316559461556225

Just revisited: https://github.com/GoogleChrome/proxy-polyfill and reduxjs/react-redux#1179 Two caveats:

  1. It doesn't support has and ownKeys handler.
  2. It doesn't detect accessing new properties. In other words, it would work only if state is only accessed by get with existing properties.

Suppose state = { counter1: 0 }, with proxy-polyfill:

  1. 'counter1' in state can't be trapped.
  2. state.counter2 can't be trapped.
@dai-shi
Copy link
Owner Author

dai-shi commented Dec 24, 2019

As in dai-shi/react-tracked#6, we need somebody to try out reactive-react-redux with polyfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant