Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proximal Operator of group-Lasso penalty with L infinity norm #54

Open
MarioOcampo opened this issue Nov 13, 2018 · 4 comments
Open

Proximal Operator of group-Lasso penalty with L infinity norm #54

MarioOcampo opened this issue Nov 13, 2018 · 4 comments
Labels

Comments

@MarioOcampo
Copy link
Contributor

The Proximal operator of the infinity norm is:
prox_InfinityNorm(x) = x − Proj{NormL1 ≤ 1}(x)

I think the implementation is not complete.
@matteofrigo, can we check it??

@daducci daducci added the bug label Nov 13, 2018
@daducci
Copy link
Owner

daducci commented Nov 16, 2018

I believe the implementation is not correct, we need to project on the L1-norm ball which requires solving a (smaller) problem. This, to be fast, need to be properly implemented in C. Meanwhile, as this norm is not used very often, I'd suggest to remove from the code the possibility to use it. @MarioOcampo , is that ok with you?

@MarioOcampo
Copy link
Contributor Author

@daducci, It is ok for me. We can change the function, maybe show a warning message, meanwhile we implement the projection.

@daducci
Copy link
Owner

daducci commented Nov 16, 2018

The PR #55 is supposed to achieve that by throwing an exception. Can you confirm?

@MarioOcampo
Copy link
Contributor Author

Yes, the execution stops, and show the message
ValueError: Wrong norm in the structured sparsity term. Choose between [2].

daducci added a commit that referenced this issue Nov 16, 2018
Temporary workaround for issue #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants