-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
options.compact() does not prevail over data.compact (as documented) #744
Comments
ValeDale
referenced
this issue
Mar 8, 2024
This again is relaed to using oc.init(...) multiple times (which is normal when you are editing online a chart). When the chart is created, each node get potentially the data.compact = true value. This is NOT reset currently if you define options.compact to be false and then perform a reinit. The current implementation only can "set" the value to true. This change, makes (in line with the documentation), sets the values of the nodes in line with options.compact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This again is related to using oc.init(...) multiple times (which is normal when you are editing online a chart).
When the chart is created, each node gets potentially the data.compact = true value. This is NOT reset currently if you define options.compact to be false and then perform a reinit. The current implementation only can "set" the value to true.
The commit also related to #741 , sets the values of the nodes in line with options.compact.
(Sorry for putting the two issues under one branch. Not sure what the best approach should have been. Anyhow, 2 different commits).
The text was updated successfully, but these errors were encountered: