Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review existing modal accessibility + replace it with polyfilled native dialog element #284

Open
alpower opened this issue Oct 2, 2018 · 0 comments

Comments

@alpower
Copy link
Contributor

alpower commented Oct 2, 2018

Look at the accessibility of our existing modal solution, and possibly replace it with a dialog modal:

Nice overview w a react compatible polyfill I reckon we should look at this as super-accessible out of box https://www.viget.com/articles/the-dialog-element/

Current Modal isn't very accessible e.g. on a cursory glance you cannot close it with the keyboard using the X) and the escape key doesn't allow closing) and tabbing allows focus down to elements on the page behind.

image

see demo of http://edenspiekermann.github.io/a11y-dialog/example/ in comparison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant