Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipped file has "Contents" folder instead of the app itself #17

Open
txbrown opened this issue Feb 19, 2024 · 2 comments
Open

Zipped file has "Contents" folder instead of the app itself #17

txbrown opened this issue Feb 19, 2024 · 2 comments

Comments

@txbrown
Copy link

txbrown commented Feb 19, 2024

I am creating an app called MIDIScout. When I run the build actions the final output is a zip folder that contains two files inside:

  • "MIDIScout.app" that seems not signed since it macOS does not allow it to run
  • "MIDIScout.app.zip" which when decompressed outputs a "Contents" folder. If I then create a "MIDIScout.app" folder and put the Contents inside, it all works fine.
  • There is no .dmg file created.

At this point I assume I am doing something wrong but I do not know what exactly.

My gon-sign.json file

{
  "source": ["./build/bin/MIDIScout.app"],
  "bundle_id": "midiscout....",
  "apple_id": {
    "username": "[email protected]",
    "password": "password",
    "provider": "XYZ"
  },
  "sign": {
    "application_identity": "Developer ID Application: ......",
    "entitlements_file": "./build/darwin/entitlements.plist"
  },
  "dmg": {
    "output_path": "./build/bin/MIDIScout.dmg",
    "volume_name": "MIDIScout"
  },
  "notarize": [
    {
      "path": "./build/bin/MIDIScout.dmg",
      "bundle_id": "...."
    }
  ]
}

My gon-notarize.json file

{
  "apple_id": {
    "username": "@env:APPLE_USERNAME",
    "password": "@env:APPLE_PASSWORD",
    "provider": "..."
  },
  "notarize": [
    {
      "path": "./build/bin/MIDIScout.app.zip",
      "bundle_id": "...."
    }
  ]
}

@tadq
Copy link

tadq commented Sep 6, 2024

Same problem with this example: https://wails.io/docs/guides/crossplatform-build

If package: true then appname.app.zip gets produced but instead of containing appname.app it contains Contents.

Looks like zip utility needs to run 1 level up instead of at the current level.

stxh added a commit to stxh/wails-build-action that referenced this issue Jan 2, 2025
@stxh
Copy link

stxh commented Jan 2, 2025

add --keepParent in ditto command line
https://github.com/stxh/wails-build-action/blob/pr/action.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants