Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace poetry with poetry-core #44

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Replace poetry with poetry-core #44

merged 1 commit into from
Sep 1, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 23, 2023

While poetry is a user-facing tool for managing a project's dependencies, poetry-core is the lighter weight PEP 517 build backend that can be used in pyproject.toml. This enables using another PEP 517 build front-end (such as build) to build the package without also depending on all of poetry.

@codecov-commenter
Copy link

Codecov Report

Merging #44 (916cb39) into master (25edf03) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files           7        7           
  Lines         375      375           
  Branches       54       54           
=======================================
  Hits          355      355           
  Misses         15       15           
  Partials        5        5           

@d5h
Copy link
Collaborator

d5h commented Aug 23, 2023

Thanks! Makes sense. Unit tests won’t cover this so I’ll have to do some manual testing before releasing when I find time in the next couple weeks.

@d5h d5h merged commit af11a9b into d5h-foss:master Sep 1, 2023
17 checks passed
@d5h
Copy link
Collaborator

d5h commented Sep 1, 2023

Did some testing and no problems found. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants