an other part of WOL fixes #2
Conversation
…s when it wants, added small hack for showing Red Alert ladders
…ug, added handling of some missing wol gameres tags
…for giving me that solution)
…n game_results was not sorted according to game_players
|
Sorry, I'm still learning this GitHub stuff. For the fixes to the previous commits you sent, couldn't you re-make those commits instead of making new ones on top of them? I guess my concern is to not have wrong commits anywhere in the history. AFAIK in Git to remake commits you can use "git rebase". For example, if I want to edit commits in the last 4 commits in the current branch I do this: Then, in the editor, I change from "pick" to "edit" every commit which I want to edit. Git will start to replay all those commits and for every commit that was changed to "edit" it will return to the shell so I can update the commit with all the fixes before continuing with "git rebase --continue" (see "man git-rebase"). It might also require to make a new pull request instead of adding to this one. This is why it is recommended to work with many branches in Git. Make a branch each time you're thinking of working on something that you would like me to merge in the official repository. Every time commits need fixed you will have to "git rebase" stuff in that branch and then push the result to your repository and make another pull request. |
|
Well d1zzy - I will look how to do that, but you should probably reverse all my commite because there may be many possible bugs. In a fact whole wol ladders are mostly an documentation and I will rewrite them. In the end I still need to recode max_packet_len which disabling gameres in current code. |
fixed uninitialized variable in channel struct!