Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in filterbank matrices #3

Open
ghostFaceKillah opened this issue Sep 22, 2019 · 0 comments
Open

Bug in filterbank matrices #3

ghostFaceKillah opened this issue Sep 22, 2019 · 0 comments

Comments

@ghostFaceKillah
Copy link

ghostFaceKillah commented Sep 22, 2019

Hi, you have bug in filterbank matrices computation.

https://github.com/chenzhaomin123/draw_pytorch/blob/master/draw_model.py

        temp,t_sigma = align(temp,sigma2)
        temp = temp / (t_sigma * 2)
        F = torch.exp(-torch.pow(temp,2))

Here you are squaring the sigma2, which is already squared.
Additionally you are squaring the 2, which is less of a problem, but still :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant