Use await import for lottie-web in LoadingAnimation
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcorvidae
approved these changes
Dec 9, 2024
Builds on my laptop are failing when trying to build SSR pages that use the LoadingAnimation, such as `/instantlaunch/[id]`. They are not failing in GitHub workflow skaffold builds, or on other dev machines, for now, but maybe this will prevent future build errors.
psarando
force-pushed
the
dynamic-loading-animation
branch
from
3ed3123 to
de22625
Compare
psarando
changed the title
lottie-web in LoadingAnimationawait import for lottie-web in LoadingAnimation
Oops, helps if I actually test these changes 😊 Turns out I used the wrong kind of dynamic/async import. Thanks for the review! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on my laptop are failing when trying to build SSR pages that use the
LoadingAnimation, such as/instantlaunch/[id].They are not failing in GitHub workflow skaffold builds, or on other dev machines, for now, but maybe this will prevent future build errors.