Make the standalone instant launch page show errors immediately #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcorvidae
commented
Dec 4, 2024
psarando
requested changes
Dec 4, 2024
|
Heh, yeah, this is a lot cleaner with WrappedErrorHandler. |
psarando
reviewed
Dec 5, 2024
| errorObject={err} | ||
| /> | ||
| ); | ||
| return <WrappedErrorHandler errorObject={error || resourceError} />; |
There was a problem hiding this comment.
This should also have a baseId, though I don't see one already setup for this button wrapper 🤔
I guess ids.BASE should work for now 🤷
There was a problem hiding this comment.
Yeah, I haven't been sure what to do for the debug IDs. I figure we don't really use them anymore really anyway, but I'll add... something, at least.
There was a problem hiding this comment.
True, they were mainly for QA tests, and we haven't added any new RobotFramework/Selenium tests in a while, but all other uses of this component have a baseId, so I figure why not keep it consistent for now 🤷
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is better than putting it behind an
ErrorTypographyWithDialogbecause there's not really much reason to just show a text error that tells you almost nothing with a detail button, on a page with nothing else. I also made it so if you close the error dialog it just redirects you to the dashboard since there's not much reason to stay on the page at that point.