Reset hasLaunched after closing the instant launch dialog #609
Conversation
…be reopened to launch again.
| @@ -74,6 +74,8 @@ function InstantLaunchButtonWrapper(props) { | |||
| window.open(`${getHost()}${ilUrl}`); | |||
| setIlUrl(null); | |||
| setOpen(false); | |||
| // reset the value so after it closes you can launch a second by reopening | |||
| setHasLaunched(false); | |||
There was a problem hiding this comment.
The main thing I'm not sure about here is: should I instead reset this in the onClick function when the dialog is reopened, leaving it set to true while the dialog is closed? Or does it not make any real difference, heh.
There was a problem hiding this comment.
I guess it doesn't seem to make a difference, but there's a lot of state and effects to juggle in this component, and it's a bit challenging to follow all the edge cases without actually interacting with it (either in dev mode or in storybook) 😅
But I think it makes more sense to me to reset it here.
| @@ -74,6 +74,8 @@ function InstantLaunchButtonWrapper(props) { | |||
| window.open(`${getHost()}${ilUrl}`); | |||
| setIlUrl(null); | |||
| setOpen(false); | |||
| // reset the value so after it closes you can launch a second by reopening | |||
| setHasLaunched(false); | |||
There was a problem hiding this comment.
I guess it doesn't seem to make a difference, but there's a lot of state and effects to juggle in this component, and it's a bit challenging to follow all the edge cases without actually interacting with it (either in dev mode or in storybook) 😅
But I think it makes more sense to me to reset it here.
|
Thanks for the reviews! If it breaks stuff to have it where I do I haven't hit it yet, anyway, so sounds like that's probably good enough for now, haha. |
this way it can be reopened to launch again.