CORE-1968 Add page titles in each DE page #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the path/file/folder in the page title for the data listing page, app category name in the app listing page, team/collection name in the teams/collections pages, and the search term in the subscriptions and search pages.
slr71
approved these changes
Oct 27, 2023
|
I almost added a 🌮 emoji by accident. I guess it would have been applicable. Tacos are good to have too. 🤣 |
💯 😋 Thanks for the review! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a basic page title to each DE page.
For example, the home page will still be titled
Discovery Environment, but this PR will update the page title for the/datapage toData - Discovery Environment, the/appslisting page toApps - Discovery Environment, the/helppage toHelp - Discovery Environment, etc.Some pages will add additional info to the page title, if available.
For example, when viewing the details of a collection or team, the collection or team name will also display in the title, as
Collection - name - Discovery EnvironmentorTeam - name - Discovery Environment; and when a user navigates to their home folder under/data/ds/cyverse/home/user, then the page title will display asData - /cyverse/home/user - Discovery Environment.When viewing subfolders of a user's home folder, then only the name of the current file or folder will display in the title (e.g.
Data - current_folder - Discovery Environment).App categories will also display in the page title when viewing the different app listings, but because the category names usually also contain the word "App", then the title will not have
App -prepended to it (e.g. justFavorite Apps - Discovery Environment).