From 865d43999d4e17b67ddf7602756b107fbefe36ac Mon Sep 17 00:00:00 2001 From: Paul Sarando Date: Fri, 17 Nov 2023 19:11:18 -0700 Subject: [PATCH 1/6] CORE-1936 Storybook fixes for analyses listing and history --- src/components/analyses/details/InfoPanel.js | 2 +- stories/analyses/Listing.stories.js | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/components/analyses/details/InfoPanel.js b/src/components/analyses/details/InfoPanel.js index de7bf88f1..1a1e94648 100644 --- a/src/components/analyses/details/InfoPanel.js +++ b/src/components/analyses/details/InfoPanel.js @@ -109,7 +109,7 @@ function InfoPanel(props) { return ; } - if (!info && !isInfoFetching && !infoFetchError) { + if (!(info?.steps || isInfoFetching || infoFetchError)) { return null; } diff --git a/stories/analyses/Listing.stories.js b/stories/analyses/Listing.stories.js index a98f0740c..66ce5f609 100644 --- a/stories/analyses/Listing.stories.js +++ b/stories/analyses/Listing.stories.js @@ -6,7 +6,7 @@ import constants from "../../src/constants"; import { mockAxios } from "../axiosMock"; -import { listing } from "./AnalysesMocks"; +import { info, listing } from "./AnalysesMocks"; import Listing from "components/analyses/listing/Listing"; import analysisFields from "components/analyses/analysisFields"; @@ -71,7 +71,8 @@ const errorResponse = { }; export const AnalysesListingTest = () => { - mockAxios.onGet(/\/api\/analyses*/).reply(200, listing); + mockAxios.onGet(new RegExp("/api/analyses/.*/history")).reply(200, info); + mockAxios.onGet("/api/analyses").reply(200, listing); mockAxios.onPost("/api/analyses/relauncher").replyOnce(500, errorResponse); mockAxios.onPost("/api/analyses/relauncher").reply((config) => { From f4c551d32ecf216837cfacac5a398df7f12a4195 Mon Sep 17 00:00:00 2001 From: Paul Sarando Date: Mon, 20 Nov 2023 16:41:55 -0700 Subject: [PATCH 2/6] CORE-1936 Update dialog action buttons to contained variants Buttons are now primary color by default, so dialog primary action buttons looked the same as "cancel" buttons. --- src/components/analyses/AnalysisCommentDialog.js | 2 +- src/components/analyses/RenameAnalysisDialog.js | 2 +- src/components/apps/AgaveAuthPromptDialog.js | 2 +- src/components/apps/PublishAppDialog.js | 2 +- src/components/apps/admin/details/AdminAppDetails.js | 2 +- src/components/apps/admin/referenceGenomes/Edit.js | 2 +- src/components/dashboard/dashboardItem/Tour.js | 2 +- src/components/data/CreateFolderDialog.js | 2 +- src/components/data/MoveDialog.js | 2 +- src/components/data/PathListAutomation.js | 2 +- src/components/data/RenameDialog.js | 2 +- src/components/data/SaveAsDialog.js | 2 +- src/components/data/listing/Listing.js | 2 +- src/components/data/viewers/FileTypeSelectionDialog.js | 2 +- src/components/help/Feedback.js | 2 +- src/components/metadata/ApplyBulkMetadataDialog.js | 2 +- src/components/metadata/CopyMetadataDialog.js | 2 +- src/components/metadata/form/AVUFormList.js | 2 +- src/components/metadata/templates/Listing.js | 2 +- src/components/metadata/templates/index.js | 2 +- .../notifications/dialogs/AdminJoinTeamRequestDialog.js | 2 +- src/components/notifications/dialogs/JoinTeamDeniedDialog.js | 2 +- src/components/preferences/Preferences.js | 2 +- src/components/sharing/index.js | 2 +- src/components/subscriptions/edit/AddSubAddon.js | 3 +-- src/components/subscriptions/edit/EditQuotas.js | 3 +-- src/components/subscriptions/edit/EditSubAddons.js | 3 +-- src/components/subscriptions/edit/EditSubscription.js | 3 +-- src/components/teams/dialogs/JoinTeamDialog.js | 2 +- src/components/tools/NewToolRequestDialog.js | 2 +- src/components/tools/ToolSelectionDialog.js | 2 +- src/components/tools/edit/EditTool.js | 4 ++-- src/components/tools/requests/Details.js | 2 +- src/components/uploads/dialog/index.js | 2 +- src/components/utils/UpdateRequestDialog.js | 2 +- src/components/vice/AccessRequestDialog.js | 2 +- src/components/vice/RunErrorDialog.js | 2 +- src/components/vice/admin/accessRequests/Listing.js | 4 ++-- src/components/vice/loading/ContactSupportDialog.js | 2 +- 39 files changed, 41 insertions(+), 45 deletions(-) diff --git a/src/components/analyses/AnalysisCommentDialog.js b/src/components/analyses/AnalysisCommentDialog.js index 500d07adb..ca6501191 100644 --- a/src/components/analyses/AnalysisCommentDialog.js +++ b/src/components/analyses/AnalysisCommentDialog.js @@ -105,7 +105,7 @@ function AnalysisCommentDialog(props) { diff --git a/src/components/notifications/dialogs/AdminJoinTeamRequestDialog.js b/src/components/notifications/dialogs/AdminJoinTeamRequestDialog.js index 0dabf6da8..bb70ae4d4 100644 --- a/src/components/notifications/dialogs/AdminJoinTeamRequestDialog.js +++ b/src/components/notifications/dialogs/AdminJoinTeamRequestDialog.js @@ -316,7 +316,7 @@ function AdminJoinTeamRequestDialog(props) { {t("common:cancel")} diff --git a/src/components/sharing/index.js b/src/components/sharing/index.js index 2c73ffa7e..3d90ca379 100644 --- a/src/components/sharing/index.js +++ b/src/components/sharing/index.js @@ -359,7 +359,7 @@ function Sharing(props) { diff --git a/src/components/tools/requests/Details.js b/src/components/tools/requests/Details.js index ce701b105..d931a0b23 100644 --- a/src/components/tools/requests/Details.js +++ b/src/components/tools/requests/Details.js @@ -61,7 +61,7 @@ function DetailsDialog(props) { } diff --git a/src/components/vice/admin/accessRequests/Listing.js b/src/components/vice/admin/accessRequests/Listing.js index e86b95e2b..13d95c9aa 100644 --- a/src/components/vice/admin/accessRequests/Listing.js +++ b/src/components/vice/admin/accessRequests/Listing.js @@ -208,7 +208,7 @@ function Listing(props) { - @@ -255,7 +255,7 @@ function Listing(props) { - diff --git a/src/components/vice/loading/ContactSupportDialog.js b/src/components/vice/loading/ContactSupportDialog.js index 5ba2fb2b3..c91339e62 100644 --- a/src/components/vice/loading/ContactSupportDialog.js +++ b/src/components/vice/loading/ContactSupportDialog.js @@ -136,7 +136,7 @@ function ContactSupportDialog(props) { {t("common:cancel")}