Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DELETE /v1/networks/{networkId}/views/{viewId}/{objectType}/{visualProperty}/bypass #93

Open
AlexanderPico opened this issue Oct 20, 2018 · 5 comments
Assignees

Comments

@AlexanderPico
Copy link
Member

Basically a generic version of the network delete method you have already:

DELETE /v1/networks/{networkId}/views/{viewId}/network/{visualProperty}/bypass 

Replacing network with {objectType}. I would like to use this to remove all bypasses for nodes and edges, for example. This is needed for basic operations like unhideAll(), which currently must DELETE for each node (very slow) or toggle the bypass value (which will continue to override any mappings).

@AlexanderPico
Copy link
Member Author

@dotasek Do you prefer tracking CyREST issues here or at Jira?

@AlexanderPico
Copy link
Member Author

Ah, I spoke too soon. Looks like this one is not the new one. Reopened.

@AlexanderPico AlexanderPico reopened this Apr 20, 2019
@dotasek
Copy link
Contributor

dotasek commented Sep 25, 2019

This is a difficult one, because of the data model. I think the correct way to handle this and other bulk updates is through the PATCH method.

If you follow the issue thread for #88, Google has a method for updating which could work:

PATCH /v1/networks/{networkId}/views/{viewId}/{objectType}?matches=ALL&bypass=true

with the content either being a value to create or update:

{
    "visualProperty": "COMPOUND_NODE_SHAPE",
    "value": "ROUND_RECTANGLE"
}

or a null value to delete

{
    "visualProperty": "COMPOUND_NODE_SHAPE",
    "value": null
}

I have to check if null is usable, because bypass might treat that as a valid value instead of a signal to delete.

@AlexanderPico
Copy link
Member Author

Should we try to implement PATCH in RCy3 and py4cytoscape per your tip above? Or is there more checking needed first, i.e., regarding null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants