Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete results for Get Layout Parameters #100

Open
AlexanderPico opened this issue Jun 1, 2019 · 3 comments
Open

Incomplete results for Get Layout Parameters #100

AlexanderPico opened this issue Jun 1, 2019 · 3 comments
Assignees
Labels

Comments

@AlexanderPico
Copy link
Member

Compare the results from CyREST:

http://localhost:1234/v1/apply/layouts/force-directed/parameters

and typing into Automation Panel:

help layout force-directed

The CyREST set is missing many paramaters

@AlexanderPico
Copy link
Member Author

This also appears to affect the PUT commad to set layout parameters, only accepting the subset that it recognizes and returning an error for the other legitimate parameters.

@dotasek
Copy link
Contributor

dotasek commented Sep 25, 2019

This is definitely an issue. Layouts use some pretty complex Tunable gymnastics, which are hidden behind very specialized interpreters for the swing dialog and the command line interface. Here's what I've come up with so far:

The current implementation ignores @ContainsTunables annotations, which results in being unable to set nested tunable sets.

If we get beyond this, there's ALSO some special case tunable handling behind nodeList, edgeAttribute and nodeAttribute, which accounts for other missing parameters.

I am part way to getting the nested tunables sorted out, but the special cases may need to interface a little differently.

@AlexanderPico
Copy link
Member Author

Any updates on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants