Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix run-gp.sh to handle git commit return values sanely #1

Open
elliefm opened this issue May 6, 2020 · 0 comments
Open

fix run-gp.sh to handle git commit return values sanely #1

elliefm opened this issue May 6, 2020 · 0 comments

Comments

@elliefm
Copy link
Contributor

elliefm commented May 6, 2020

this refers to the git commit ... || true ## FIXME line, which is there because git commit exits with a failure status if there were no changes to commit, and we want it to ignore this specific case. a better solution would check the failure code, and only ignore the 'nothing to commit' failure, but keep all other failures as failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant