Optionally raise on empty hash filter definitions #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've recently spent several hours debugging a problem that was caused by an empty hash definition ```ruby required do hash :hash_name end ``` Such definition discards any hash content being passed in, which is very confusing and I reckon rarely useful, but very unintuitive interface (found other 3 bugs in the codebase caused by the exact same problem). This change makes such definitions raise, but only if Mutations.raise_on_empty_hash_filter is set to true (defualt false). Such optional raising avoids breaking change. Overall, I recommend changing the interface to raise on bogus definition as a default, instead of the opt-in.
mariokostelac
force-pushed
the
mario/raise_on_empty_hash
branch
from
f81a8e9 to
d245226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently spent several hours debugging a problem that was caused by an empty hash definition
Such definition discards any hash content being passed in, which is very
confusing and I reckon rarely useful, but very unintuitive interface
(found other 3 bugs in the codebase caused by the exact same problem).
This change makes such definitions raise, but only if
Mutations.raise_on_empty_hash_filter is set to true (defualt false).
Such optional raising avoids breaking change.
Overall, I recommend changing the interface to raise on bogus definition
as a default, instead of the opt-in.