Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vendored sources #1

Open
3 tasks
sneurlax opened this issue Apr 12, 2024 · 4 comments
Open
3 tasks

Use vendored sources #1

sneurlax opened this issue Apr 12, 2024 · 4 comments

Comments

@sneurlax
Copy link
Member

@MrCyjaneK
Copy link

If you add monero_c as a git submodule (as it is added currently) it is getting pinned to current hash, including all scripts and patches in that repo - so it is already pinned

@sneurlax
Copy link
Member Author

sneurlax commented Apr 14, 2024

It is added like so:

https://github.com/MrCyjaneK/stack_wallet/blob/monerodart/.gitmodules#L7-L10

So changes could be pushed to #rewrite-wip after the review and those changes could reach end users without review.

There would be less of an issue if we used the current-latest commit hash on rewrite-wip

@MrCyjaneK
Copy link

This is just source information, actuall pinned hash can be seen here: https://github.com/cypherstack/stack_wallet/pull/831/files#diff-40feb834325610129faed3d162eb16258d73b063549934dae33dde4a61c775e8

it is being pinned to hash 738608....., so no matter what I push to the branch it will checkout that commit.

@sneurlax
Copy link
Member Author

Right you are! Then this may be closed

sneurlax pushed a commit that referenced this issue Apr 19, 2024
Windows fix: do not fail on `git clone` if repo already exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants