Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkflowService/GQuery seem to have issues when fields are aliased in the query #403

Closed
kinow opened this issue Feb 13, 2020 · 1 comment · Fixed by #419
Closed

WorkflowService/GQuery seem to have issues when fields are aliased in the query #403

kinow opened this issue Feb 13, 2020 · 1 comment · Fixed by #419
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kinow
Copy link
Member

kinow commented Feb 13, 2020

Describe the bug

A query such as:

subscription {
  cyclePoints: familyProxies(ids: ["root"]) {
    cyclePoint
  }
  familyProxies (exids: ["root"], sort: { keys: ["firstParent"]}) {
    id
  }
}

Ends up with two FamilyProxy selections in the GraphQL Query JS object. One of them contains an "alias" cyclePoints as specified in the query.

image

But the Vuex store ends up with an object missing cyclePoints. Probably just needs to use the alias when it is present, or the name otherwise.

image

Release version(s) and/or repository branch(es) affected?

Steps to reproduce the bug

Use a GraphQL query with an alias.

Expected behavior

A JS object is added to the store with both familyProxies and cyclePoints.

image

Screenshots

Additional context

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@kinow kinow added the bug Something isn't working label Feb 13, 2020
@kinow
Copy link
Member Author

kinow commented Feb 13, 2020

The alias comes from an improvement reported in #354 to avoid going through family proxies to find the cycle points.

@kinow kinow mentioned this issue Feb 20, 2020
12 tasks
@kinow kinow added this to the 0.3 milestone Feb 20, 2020
kinow pushed a commit to kinow/cylc-ui that referenced this issue Feb 20, 2020
@kinow kinow self-assigned this Feb 20, 2020
kinow pushed a commit to kinow/cylc-ui that referenced this issue Mar 1, 2020
kinow pushed a commit to kinow/cylc-ui that referenced this issue Mar 15, 2020
@kinow kinow modified the milestones: 0.3, 0.2 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant