feat: close connections that exceeds opts.idleTimeout #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyjake
force-pushed
the
feat-close-idle-connections
branch
from
6c14bd4 to
48476a1
Compare
cyjake
force-pushed
the
feat-close-idle-connections
branch
from
48476a1 to
6309822
Compare
JimmyDaddy
reviewed
Aug 17, 2021
| return connection; | ||
| } | ||
| await new Promise(resolve => queue.push(resolve)); | ||
| return await this.getConnection(); |
There was a problem hiding this comment.
This may cause infinite loop in some edge case. How about set a waiting timeout, then throw error while waiting timeout and no connection available
There was a problem hiding this comment.
This is the default behavior that the mysql client supports, when connection pool is drained, wait for connection being released.
| this.emit('release', connection); | ||
|
|
||
| const { queue } = this; | ||
| while (queue.length > 0) { |
There was a problem hiding this comment.
the queue use for what? It seems store resolve functions.
There was a problem hiding this comment.
It's a simple hack for referencing hanging awaits in getConnection, when new connection is available, begin dequeue continue previous blocking jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #148, closes #60 with a mocked Pool and Connection for sqlite driver