チャットのスクロール制御リファクタ #279
Open
チャットのスクロール制御リファクタ #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mori-atsushi
commented
May 19, 2018
| @@ -45,7 +47,12 @@ class ChatFragmentViewModel @Inject constructor( | |||
| ChatViewModel(ObservableField(it)) | |||
| } | |||
| .subscribe { | |||
| val isScrolledToEnd = scrolledToEnd.get() | |||
| scrolledToEnd.set(false) | |||
There was a problem hiding this comment.
ホントはこの意味不明なこの文を書きたくない。
スクロールされたタイミングで scrolledToEnd を更新してるんだけど、データを追加した時にスクロールはされないので、実際の状態と保持している状態が食い違ってしまう。
そして、 false から true になる時のみメソッドが呼ばれるので、明示的に false にしてあげないとスクロールされないことになる。
There was a problem hiding this comment.
自動でこれなってほしいのは分からなくも無いんだけど，まあしょうがないし違和感の原因はsubscribeのなかでごちゃごちゃ書いていることなのでこの一連の処理をメソッドで切り出せばいいのかなぁとは思う．
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #276
viewからviewModelに持ってきた。
若干まだ汚い。