Types are not being detected in v2

[SimeonC]

It looks like in v2 the exports field in the package.json is missing meaning that not all configurations for tsconfig.json are supported.

For example if you open up the react-express stackblitz, it compiles fine but vavite (and others admittedly) have red squiggly lines under them as the types cannot be found.

Changing node_modules/vavite/package.json to be the following worked for me locally; (took inspiration from the package definition of vite but vavite needs to be different for some reason.

  "type": "module",
  "module": "./dist/index.js",
  "types": "./dist/index.d.ts",
  "files": [
    "dist",
    "*.d.ts",
    "node-loader.mjs",
    "suppress-loader-warnings.cjs"
  ],
  "exports": {
    ".": {
      "import": "./dist/index.js",
      "require": "./dist/index.cjs",
      "types": "./dist/index.d.ts"
    },

My tsconfig.json relevant settings are;

    "module": "ES2020",
    "target": "ESNext",
    "moduleResolution": "Bundler",

[SimeonC]

Sorry about this looks like it is working correctly. Turns out I just didn't have it included in my tsconfig.json so it silently failed to load for some unknown reason. Typescript configuration is hard 😂

[cyco130]

Typescript configuration is hard 😂

Tell me about it 😅

I prefer the typesVersions trick which I find cleaner than manually specifying each type definition file.

Just double-checked in any case and Are the Types Wrong suggests that everything's fine:

• vavite/vite-dev-server and vavite/http-dev-server are not meant to be consumed from CommonJS (they're virtual modules meant to be consumed from a Vite app), so the failures for "node16 (from CJS)" are OK.
• vavite/node-loader and vavite/suppress-loader-warnings don't need types, so those failures are also OK.

publint just improved its type resolution error detection, so hopefully we'll have more confidence in our types from now on.

[SimeonC]

Nice, I hadn't heard of publint before. I'll probably try use that on my projects too.

Thanks for taking the time to reply, that error caused by not including the config file had me frustrated for a day before opening this. Annoyingly enough VSCode will happily tell you TS is running on the file, but give cryptic errors until it's included properly.

[jensbodal]

Sorry about this looks like it is working correctly. Turns out I just didn't have it included in my tsconfig.json so it silently failed to load for some unknown reason. Typescript configuration is hard 😂

What was not included in your tsconfig.json?

[SimeonC]

Sorry about this looks like it is working correctly. Turns out I just didn't have it included in my tsconfig.json so it silently failed to load for some unknown reason. Typescript configuration is hard 😂

What was not included in your tsconfig.json?

The vite.config.ts file, had included subfolders but not root level ts files

[jensbodal]

Ah thanks just arrived at the same conclusion :)