-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add random behavior for size of sink request #550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is going into Cycamore, we might want to discuss what random sink behaviors make sense. I know you want a way to demo them all, but not sure any "Int" method makes sense?
After deciding if fractional or fixed μ and σ makes more sense, my next question is how (if?) to restrict the user's choice of μ and σ. I expect few use cases would want to set the mean higher than the maximum allowable value ( On the other hand, I worry that a lack of restrictions will result in users accidentally setting a distribution with a negligible probability of picking an allowable value-- we don't want to have to sample 100,000 times to get one value |
Cyclus version used for github actions needs to be updated with the PRNG (cyclus/cyclus#1599) for the build/test workflow to pass |
Can you rebase this against |
OK - I was thrown off by seeing failures of the CircleCI tests... but maybe those are lingering and not relevant. |
random_size
has default None, but alsofourtwo options that call the PRNG from the context:one ofthe normal distributions, two additional parametersrandom_size_mean
andrandom_size_stddev
are used as fractions of the maximum request size (calculated at each timestepRequestAmt()
)Checklist
closes Design unit test for randomness in request size for Sink archetype #556