You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@gonuke suggested moving some of the duplicate definitions between src/deploy_inst_test.h and src/manager_inst_tests.h into a separate header that could be read in by both, but that was not possible without creating a dummy prototype within cycamore that was blank. So the duplications remain, until a better solution is found.
Also, with the use of TestProducer by both src/deploy_insts_tests.cc and src/manager_insts_tests/cc, it seems that all of the information from the unit tests are stored while the tests are being run so this is not a major issue for now, since all of the unit tests and regression tests are running and passing. We should revisit this in the future though.
@gonuke suggested moving some of the duplicate definitions between
src/deploy_inst_test.h
andsrc/manager_inst_tests.h
into a separate header that could be read in by both, but that was not possible without creating a dummy prototype within cycamore that was blank. So the duplications remain, until a better solution is found.Also, with the use of
TestProducer
by bothsrc/deploy_insts_tests.cc
andsrc/manager_insts_tests/cc
, it seems that all of the information from the unit tests are stored while the tests are being run so this is not a major issue for now, since all of the unit tests and regression tests are running and passing. We should revisit this in the future though.Originally posted by @abachma2 in #529 (comment)
The text was updated successfully, but these errors were encountered: