Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load route from ID needs multiplexing support #2

Open
mvl22 opened this issue Jan 8, 2021 · 0 comments
Open

Load route from ID needs multiplexing support #2

mvl22 opened this issue Jan 8, 2021 · 0 comments

Comments

@mvl22
Copy link
Member

mvl22 commented Jan 8, 2021

Currently, loading a route from an ID, in loadRouteFromId does three separate calls from journey.retrieve which is inefficient:

https://github.com/cyclestreets/routing-ui/blob/master/js/routing.js#L2203-L2219

This should be replaced with multiplexing support when _settings.multiplexedStrategies is enabled, as in loadRoute:

https://github.com/cyclestreets/routing-ui/blob/master/js/routing.js#L2253-L2256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvl22