Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small primary #76

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Small primary #76

merged 6 commits into from
Oct 22, 2024

Conversation

gam6itko
Copy link
Contributor

@gam6itko gam6itko commented Sep 22, 2024

🔍 What was changed

If I have column like this

#[Cycle\Column(type: 'smallPrimary', unsigned: true)]
private ?int $id = null;

I've got this error

[Cycle\Schema\Exception\RegistryException]
Entity `entityName` must have defined primary key in vendor/cycle/schema-builder/src/Relation/RelationSchema.php:137

📝 Checklist

  • How was this tested:
    • Tested manually
    • Unit tests added

@gam6itko gam6itko marked this pull request as draft September 22, 2024 08:44
@gam6itko gam6itko marked this pull request as ready for review September 22, 2024 09:13
@roxblnfk roxblnfk merged commit 32cff8f into cycle:2.x Oct 22, 2024
37 of 38 checks passed
@gam6itko gam6itko deleted the small-primary branch October 22, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants