From c9590f1f3662f1a4f0868d352c48e49dc28f0ee5 Mon Sep 17 00:00:00 2001 From: sokari Date: Fri, 6 Dec 2024 14:06:41 +0100 Subject: [PATCH] chore: deprecated GitHub Jobs summary write --- .github/workflows/actions-example.yml | 1 - README.md | 12 +++++------- start.sh | 6 ------ worker/app/site-builder.ts | 11 ----------- 4 files changed, 5 insertions(+), 25 deletions(-) diff --git a/.github/workflows/actions-example.yml b/.github/workflows/actions-example.yml index cdb5c98..30cbcd0 100644 --- a/.github/workflows/actions-example.yml +++ b/.github/workflows/actions-example.yml @@ -51,7 +51,6 @@ jobs: -e WEBSITE_EXPIRES=${{ github.event.inputs.website-expires }} \ -e KEEP_RETRIES=${{ github.event.inputs.keep-retries }} \ -e KEEP_HISTORY=${{ github.event.inputs.keep-history }} \ - -v $GITHUB_STEP_SUMMARY:/github/summary.txt \ -v {{ github.workspace }}/assets/allure-results:/allure-results \ -v ${{ github.workspace }}/gcp-key.json:/credentials/gcp-key.json \ sokari/allure-docker-deploy:latest \ No newline at end of file diff --git a/README.md b/README.md index 26456f5..bc562b0 100644 --- a/README.md +++ b/README.md @@ -50,7 +50,6 @@ jobs: -e KEEP_HISTORY=true \ -e KEEP_RETRIES=true \ -e GITHUB=true -# -v $GITHUB_STEP_SUMMARY:/github/summary.txt \ -v ${{ github.workspace }}/allure-results:/allure-results \ -v ${{ secrets.GCP_CREDENTIALS_FILE_PATH }}:/credentials/gcp-key.json \ sokari/allure-docker-deploy:latest @@ -59,7 +58,6 @@ jobs: Tips: 1. Use a different value `WEBSITE_ID` in every test run. `${{ github.ref }}` is a good example. 2. Set the WEBSITE_EXPIRES value appropriately to deallocate old test run sites. -3. Mount the `$GITHUB_STEP_SUMMARY` file to see your test report URL in GitHub Actions job summary ### Local test runs #### Step 1: Pull the Docker Image ```bash @@ -152,11 +150,11 @@ Nevertheless, you have free 5GB of storage before you will incur any charges_ --- ## Where to find your hosted test report URL -| Platform | Report URL output location | -|-----------|----------------------------------------------------| -| GitHub | Logs, Firebase console, GitHub Actions job summary | -| Gitlab | Logs, Firebase console | -| Localhost | Logs, Firebase console | +| Platform | Report URL output location | +|-----------|-------------------------------------| +| GitHub | Logs, Firebase console, Slack (WIP) | +| Gitlab | Logs, Firebase console, Slack (WIP) | +| Localhost | Logs, Firebase console | ### URL in logs example
Firebase CLI console output
diff --git a/start.sh b/start.sh index 15ec02b..82043e4 100644 --- a/start.sh +++ b/start.sh @@ -32,12 +32,6 @@ if [ ! -d "$MOUNT_POINT" ]; then exit 1 fi -GITHUB_SUMMARY_FILE="/github/summary.txt" -if [ ! -d "$GITHUB_SUMMARY_FILE" ]; then - export GITHUB_SUMMARY_FILE - echo "Git summary file directory mounted" -fi - if [ -n "$TTL_SECS" ]; then if ! [[ "$TTL_SECS" -eq "$TTL_SECS" && "$TTL_SECS" -ge 0 ]]; then echo "Error: $TTL_SECS must be a positive number" diff --git a/worker/app/site-builder.ts b/worker/app/site-builder.ts index efadeff..abc14e0 100644 --- a/worker/app/site-builder.ts +++ b/worker/app/site-builder.ts @@ -83,17 +83,6 @@ async function publishToFireBaseHosting() { if (match && match[2]) { const url = match[2] console.log(`Allure test report URL: ${url}`) - const githubSummaryFile = process.env.GITHUB_SUMMARY_FILE - if (githubSummaryFile) { // Add URL to GitHub workflow summary - builder.clear() - builder.append(`echo "Allure test report URL :globe_with_meridians: : ${url}"`).append(' ') - .append('>>').append(' ').append(`${githubSummaryFile}`) - try { - await exec(builder.toString()) - } catch (e) { - console.warn('Failed to write site URL to GitHub job summary') - } - } } else { console.warn('Could not parse URL from hosting.') console.log(stdout)