Fix Windows EC2 onboarding when using a secondary AWS account. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When onboarding a Windows instance from a secondary AWS account, the Elasticity lambda is configured to use an AssumeRole called CyberArk-AOB-AssumeRoleForElasticityLambda in order to acquire the necessary permissions. A typo in instance_processing::get_instance_password_data() prevents the session token from being retrieved, and consequently to onboard the instance. This commit fixes the issue.
NoamALK
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When onboarding a Windows instance from a secondary AWS account, the Elasticity lambda is configured to use an AssumeRole called CyberArk-AOB-AssumeRoleForElasticityLambda in order to acquire the necessary permissions.
A typo in instance_processing::get_instance_password_data() prevents the session token from being retrieved, and consequently to onboard the instance.
What does this PR do?
This PR fixes the bug described above.
What ticket does this PR close?
Resolves #61
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or