Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate CWRC-Writer button config #32

Open
jefferya opened this issue May 14, 2018 · 3 comments
Open

Consolidate CWRC-Writer button config #32

jefferya opened this issue May 14, 2018 · 3 comments
Assignees

Comments

@jefferya
Copy link
Collaborator

The goal: refactor code to set all CWRC-Writer button config in one location. At present, the config is spread across multiple files:

Message from Andrew - Slack
In order to simplify my own testing, I've kept my JS that modifies buttons1 ( https://github.com/cwrc/Islandora-CWRC-Writer/blob/master/js/islandora_cwrc_writer.js#L23-L26 ) but I'm thinking that this should be consolidated at some point

@SusanBrown
Copy link

@ajmacdonald Can we have an estimate on this pls?

@ajmacdonald
Copy link
Collaborator

@SusanBrown I'm hesitant to guess. I'm not sure it's a good idea for me to tackle this on my own as it involves PHP coding and parts of the Islandora module that I'm not familiar with.

@SusanBrown
Copy link

@nikathone Another one we think you could tackle. Consult with @ajmacdonald and @jefferya as needed about specifics of the CWRC-Writer integration module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants