Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated CWRC-Writer: radio buttons in all dialogs are not rendering the label when selected #29

Closed
ilovan opened this issue May 10, 2018 · 6 comments

Comments

@ilovan
Copy link
Contributor

ilovan commented May 10, 2018

screen shot 2018-05-10 at 3 03 58 pm

@ajmacdonald , could you look at this as soon as possible, rectify in dev-06 and let me know what commit should Brad pull into the CWRC beta code to apply this fix (we installed the new CWRC_Writer there this morning)

@ajmacdonald
Copy link
Collaborator

There is a conflict between the cwrc-writer css and the islandora css. I've already tried to make my css more specific by adding the .cwrc scope to it but the situation is complicated by the !important flag from the islandora css. It's difficult to make my css more specific than it already is. Removing the !important flag from the islandora css fixes the issue but there's probably a reason why they had it there in the first place.
style conflict

@ajmacdonald
Copy link
Collaborator

In general there are multiple conflicts between the css for cwrc-writer and the de_theme.css used by Islandora (another e.g. #30 (comment) ). It would be worth having a conversation with the Islandora team about how to best resolve this.

@SusanBrown
Copy link

We are certainly seeing evidence of this in our testing. For instance, the right click menu on entities in the entity panel has now dropped down far to the left, on to of the main editing panel, and so has apparently disappeared entirely.

It would be great if you and @bradklaver or Luke at Digital Echidna could connect about this asap to try to figure out how to handle it.

@bradklaver
Copy link
Member

Having a look at this.

@bradklaver
Copy link
Member

Fixed on test

@ilovan
Copy link
Contributor Author

ilovan commented Nov 2, 2018

fixed on Beta
image

Thank you , @bradklaver

@ilovan ilovan closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants