Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make content of scholarly notes and citations visible to to users in the read-only mode in a mouse-over pop-up #39

Closed
ilovan opened this issue Jan 30, 2018 · 10 comments
Assignees

Comments

@ilovan
Copy link
Contributor

ilovan commented Jan 30, 2018

@ajmacdonald , is this the right repo to put this issue in? I know that we only have the read-only mode in the CWRC-integrated Writer only, so I am thinking that you may want it placed in https://github.com/cwrc/Islandora-CWRC-Writer

@ajmacdonald
Copy link
Collaborator

@ilovan this is the right repo

@ajmacdonald ajmacdonald self-assigned this Feb 1, 2018
@ilovan ilovan changed the title Make mini-CWRC-Readers to display the content of scholarly notes and citations to users in reading mode Make content of scholarly notes and citations visible to to users in the read-only mode in a mouse-over pop-up Feb 6, 2018
@ilovan
Copy link
Contributor Author

ilovan commented Feb 6, 2018

@ajmacdonald to look into whether it would be possible to make these mouse-over pop-ups display tag-determined formatting.

@ajmacdonald
Copy link
Collaborator

ddcc34d

@ajmacdonald
Copy link
Collaborator

In order to test this, we'll need a read only mode available somewhere. So I guess this is reliant on cwrc/Islandora-CWRC-Writer#18

@ilovan
Copy link
Contributor Author

ilovan commented Feb 15, 2018

I believe there is already a read-only mode available in the dev-06 version, as it is currently installed in dev-06.
https://cwrc-dev-06.srv.ualberta.ca/islandora/object/islandora%3A3f8b2457-cc35-4441-b1a8-d584ef803214/view/default#islandora:3f8b2457-cc35-4441-b1a8-d584ef803214

Seems to be working fine to me. Can you push this code to the dev-06 version of the CWRC-Writer code and let me know when it's done to test it?

@ajmacdonald
Copy link
Collaborator

@ilovan yes I'll do that. FYI I can't easily selectively push updates so many other changes/fixes will also be deployed to dev-06.

@ilovan
Copy link
Contributor Author

ilovan commented Feb 15, 2018 via email

@ajmacdonald
Copy link
Collaborator

@ilovan done

@ilovan
Copy link
Contributor Author

ilovan commented Feb 16, 2018 via email

@ilovan
Copy link
Contributor Author

ilovan commented Mar 2, 2018

confirmed on Prod Git-Writer and dev-06 for notes; citations still display rather awkwardly, but I will create a separate issue for that

@ilovan ilovan closed this as completed Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants