-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make content of scholarly notes and citations visible to to users in the read-only mode in a mouse-over pop-up #39
Comments
@ilovan this is the right repo |
@ajmacdonald to look into whether it would be possible to make these mouse-over pop-ups display tag-determined formatting. |
In order to test this, we'll need a read only mode available somewhere. So I guess this is reliant on cwrc/Islandora-CWRC-Writer#18 |
I believe there is already a read-only mode available in the dev-06 version, as it is currently installed in dev-06. Seems to be working fine to me. Can you push this code to the dev-06 version of the CWRC-Writer code and let me know when it's done to test it? |
@ilovan yes I'll do that. FYI I can't easily selectively push updates so many other changes/fixes will also be deployed to dev-06. |
Would that deploy all the code before that particular fix?
Can you please briefly review the pipelines between "review / QA 1" and
"Deploy to dev-06" and move all the issues for which you are updating the
code on dev-06 for to the "Review / QA final" pipeline?
Thanks.
…On Thu, Feb 15, 2018 at 11:11 AM, Andrew ***@***.***> wrote:
@ilovan <https://github.com/ilovan> yes I'll do that. FYI I can't easily
selectively push updates so many other changes/fixes will also be deployed
to dev-06.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGS1hgIjDsKs-0W10CfffOZPCBlVcG0Sks5tVHNRgaJpZM4Ryy_C>
.
--
Mihaela Ilovan
Project Manager
Canadian Writing Research Collaboratory
University of Alberta
4-20 Humanities Centre
Edmonton, AB
Canada T6G 2E5
780-966-4507
[email protected]
|
@ilovan done |
thanks, will get on testing.
…On Fri, Feb 16, 2018 at 12:36 PM, Andrew ***@***.***> wrote:
@ilovan <https://github.com/ilovan> done
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGS1hjYEWrSKky3d7lMy6Hz5j84RdyOeks5tVdijgaJpZM4Ryy_C>
.
--
Mihaela Ilovan
Project Manager
Canadian Writing Research Collaboratory
University of Alberta
4-20 Humanities Centre
Edmonton, AB
Canada T6G 2E5
780-966-4507
[email protected]
|
confirmed on Prod Git-Writer and dev-06 for notes; citations still display rather awkwardly, but I will create a separate issue for that |
@ajmacdonald , is this the right repo to put this issue in? I know that we only have the read-only mode in the CWRC-integrated Writer only, so I am thinking that you may want it placed in https://github.com/cwrc/Islandora-CWRC-Writer
The text was updated successfully, but these errors were encountered: