Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access from python script #61

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

deekaey
Copy link
Contributor

@deekaey deekaey commented Apr 18, 2023

  • Enable dlsc being called by python script
  • Workaround for single site creation: creating first small bounding box around lat/lon pair and selecting then nearest gridcell.

@cwerner
Copy link
Owner

cwerner commented Apr 19, 2023

Build for python 3.8 is failing. Seems like the current rasterio version is >=3.9. We need to pin it to a previous version or bump our minimal version to 3.9, too (removing the 3.8 build stage). Actually, maybe reverting from the GitHub dev versions of Fiona and rasterio in our requirements would be enough since the tagged version should be >=3.8as far as I can see on their release page: https://github.com/rasterio/rasterio/releases

Also, not sure if some tests should be added for the change?

@cwerner
Copy link
Owner

cwerner commented Apr 20, 2023

@deekaey : I think we need to add continue-on-error: true to the last stage.

    - name: Pytest coverage comment
      continue-on-error: true
      uses: MishaKav/pytest-coverage-comment@main
      if: ${{ matrix.python-version == '3.10' }}
      with:
        pytest-coverage-path: ./pytest-coverage.txt
        junitxml-path: ./pytest.xml

See https://stackoverflow.com/a/70048004

@cwerner
Copy link
Owner

cwerner commented Feb 9, 2024

Krauso!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants