Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about Updating Memory Module #57

Open
crazyn2 opened this issue Dec 27, 2023 · 1 comment
Open

Questions about Updating Memory Module #57

crazyn2 opened this issue Dec 27, 2023 · 1 comment

Comments

@crazyn2
Copy link

crazyn2 commented Dec 27, 2023

I've read your paper which is an excellent work. But when I was reading your code, I have questions about the procedures of updating memory module.
From my perspective, the m_items in Train.py is the memory module, whose grad is False. So the backward operations of the separateness loss and compactness_loss do not have any impact on memory. However, the paper discusses how these two loss functions can influence memory. The reason for including these two loss functions in the overall loss of Train.py is not explicitly stated. My questions are similar to #52

@crazyn2
Copy link
Author

crazyn2 commented Dec 29, 2023

Terrible codes in this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant