Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update a skeleton svg using labels_api.partial_update, Task.update, or via UI #8585

Open
2 tasks done
matt-deboer opened this issue Oct 22, 2024 · 2 comments
Open
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@matt-deboer
Copy link

matt-deboer commented Oct 22, 2024

Actions before raising this issue

  • I searched the existing issues and did not find anything similar.
  • I read/searched the docs

Steps to Reproduce

  1. Using the python sdk, create a task using the high level api (client.tasks.create_from_data), creating a label of type skeleton, but with empty svg value (since I cannot find how to properly create an svg without knowing the ids of the sub-labels which have not yet been created).
  2. After the task is created, build an appropriate 'svg' value and attempt to update it with the high level api or the low level labels_api.
  3. Notice that the update is successful, but the 'svg' value is ignored

Also note that updates applied in the GUI work the same way (update 'success' but no changes applied).

Expected Behavior

The svg value should be updated, or at least an error thrown indicating that the value is not valid for update.

Possible Solution

Fix code to validate and update the value, or at least mark the 'svg' field as non-updatable.
Specifically, in cvat/apps/engine/serializers.py, in the case where a label is being updated, there is no corresponding logic to deal with a skeleton type.

Context

No response

Environment

No response

@matt-deboer matt-deboer added the bug Something isn't working label Oct 22, 2024
@zhiltsov-max
Copy link
Contributor

Hi, skeleton label points cannot be edited after a label is declared, it's not supported. I agree that an explanatory error message should be issued in such cases.

@MSDEV0630
Copy link

Hello, Has this issue been resolved? I would like to resolve this issue if it has not been I would like to take this task on. Please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants