Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sus4 chords in root-finding algorithm #1650

Open
jacobtylerwalls opened this issue Sep 24, 2023 · 0 comments
Open

Support sus4 chords in root-finding algorithm #1650

jacobtylerwalls opened this issue Sep 24, 2023 · 0 comments

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Sep 24, 2023

Motivation
sus4 chords are common enough that we could support them in the root-finding algorithm.

Feature summary

>>> from music21 import chord
>>> chord.Chord('F B- C E-').root()  # expected F
<music21.pitch.Pitch C>

Proposed implementation
rootnessFunction() might possibly prefer adjacent values (e.g. having a fifth and seventh trumps having a third and a seventh), but this would need to be tested (makes less sense in the case of adjacent ninth and eleventh, etc.)

Intent

[?] I plan on implementing this myself.
[ ] I am willing to pay to have this feature added.
[x] I am starting a discussion with the hope that community members will volunteer their time to create this. I understand that individuals work on features of interest to them and that this feature may never be implemented.

Reported on m21 list Sept. 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant