Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events / API still broken #41

Open
kaber2 opened this issue Feb 14, 2024 · 1 comment
Open

Events / API still broken #41

kaber2 opened this issue Feb 14, 2024 · 1 comment
Labels
feedback Further information is requested

Comments

@kaber2
Copy link

kaber2 commented Feb 14, 2024

I can see that you made a few improvements to the horrific API and Events used in the old implementation, however, what's up with constantly not exporting vital configuration parameters?

Looking at the "NG" pools, I immediately notice that there is no way to get at the rate oracles. The factory doesn't remember or provide them, the pool uses private variables. Seriously guys, you finally had a chance to fix the unholy mess you've created, but it continues on just like before. Seems we continue to need tracing, active probing etc to get at simple information.

Please just quit and find something else to do.

@bout3fiddy
Copy link
Collaborator

bout3fiddy commented Mar 13, 2024

Hi @kaber2. Thanks for the feedback. I wasn't aware of your needs when I wrote the contracts. NG represents the start of the next generation of Curve's AMM contracts, and this is our first-gen one. We can always improve it: What events would you like to see? What kind of specific feedback do you have for me for the next ones so I can create a well-defined task and prioritise it as the team sees fit?

I'm in favour of not exposing public methods that are not state-changing and contracts that do not emit events. I hope we can move in that direction when integrators/searchers use shadow contracts that mimic lightweight production contracts. This way, we don't need to know what specific integrators need.

My apologies and I'm happy to gather some constructive feedback! I'm unfortunately not going to quit and find something else to do just yet :).

@bout3fiddy bout3fiddy added the feedback Further information is requested label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants