You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I can see that you made a few improvements to the horrific API and Events used in the old implementation, however, what's up with constantly not exporting vital configuration parameters?
Looking at the "NG" pools, I immediately notice that there is no way to get at the rate oracles. The factory doesn't remember or provide them, the pool uses private variables. Seriously guys, you finally had a chance to fix the unholy mess you've created, but it continues on just like before. Seems we continue to need tracing, active probing etc to get at simple information.
Please just quit and find something else to do.
The text was updated successfully, but these errors were encountered:
Hi @kaber2. Thanks for the feedback. I wasn't aware of your needs when I wrote the contracts. NG represents the start of the next generation of Curve's AMM contracts, and this is our first-gen one. We can always improve it: What events would you like to see? What kind of specific feedback do you have for me for the next ones so I can create a well-defined task and prioritise it as the team sees fit?
I'm in favour of not exposing public methods that are not state-changing and contracts that do not emit events. I hope we can move in that direction when integrators/searchers use shadow contracts that mimic lightweight production contracts. This way, we don't need to know what specific integrators need.
My apologies and I'm happy to gather some constructive feedback! I'm unfortunately not going to quit and find something else to do just yet :).
I can see that you made a few improvements to the horrific API and Events used in the old implementation, however, what's up with constantly not exporting vital configuration parameters?
Looking at the "NG" pools, I immediately notice that there is no way to get at the rate oracles. The factory doesn't remember or provide them, the pool uses private variables. Seriously guys, you finally had a chance to fix the unholy mess you've created, but it continues on just like before. Seems we continue to need tracing, active probing etc to get at simple information.
Please just quit and find something else to do.
The text was updated successfully, but these errors were encountered: