Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learning Loss for AL query wrong idxs #3

Open
grant-m-s opened this issue Jun 2, 2023 · 0 comments
Open

Learning Loss for AL query wrong idxs #3

grant-m-s opened this issue Jun 2, 2023 · 0 comments

Comments

@grant-m-s
Copy link

https://github.com/cure-lab/deep-active-learning/blob/57aaaf3d3b166ac8919ddd774556aac3ec2676e3/query_strategies/learning_loss_for_al.py#LL281C1-L281C39

According to the original paper:
If we can predict the loss of a data point, it becomes possible to select data points that are expected to have high losses. The selected data points would be more informative to the current model.

This implies we should be taking the maximum values from the uncertainties arg[-n:]. Your current implementation returns the minimum arg[:n] and so is returning the least informative points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant