Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virus check notifications not being sent in production #711

Open
3 tasks
bess opened this issue Aug 23, 2017 · 2 comments
Open
3 tasks

Virus check notifications not being sent in production #711

bess opened this issue Aug 23, 2017 · 2 comments
Labels
bug future scope

Comments

@bess
Copy link

bess commented Aug 23, 2017 •
edited
Loading

On staging-etd and qa-etd, uploaded virus files are being deleted, but no notification is being sent

  • Ensure a notification is sent when a virus is detected
  • Improve logging so it's easier to determine whether virus checking is working in a production environment
  • Ensure virus detection and notification happens for browse-everything uploaded files as well as locally uploaded files
@bess bess added this to the Public Access 1.0 milestone Aug 23, 2017
@bess bess self-assigned this Aug 23, 2017
@bess bess modified the milestones: Release 1.1, Public Access 1.0 Aug 23, 2017
@bess bess added on deck and removed in progress labels Aug 23, 2017
@bess
Copy link
Author

bess commented Aug 23, 2017

Currently, notifications are being sent when a certain exception is encountered. However, because of the way background jobs is running in production vs the way it's run in development and test, that exception is never encountered. I need to re-think how we detect that a virus has been encountered and trigger the notification. I have a local branch where I've made progress but this will have to wait for our next release.

@bess bess removed this from the Release 1.1 milestone Nov 14, 2017
@bess bess removed their assignment Jan 26, 2018
@bess bess added this to the Release 1.3 milestone Jan 26, 2018
@no-reply no-reply self-assigned this Feb 1, 2018
@bess bess removed this from the Release 1.3 milestone Feb 9, 2018
@bess bess added on deck and removed ready labels Feb 9, 2018
@no-reply
Copy link

no-reply commented Apr 5, 2018

Do we want to refactor the clamby code to look more like curationexperts/mahonia@b0e9763 ?

@mark-dce mark-dce removed the on deck label Jun 12, 2018
@bess bess removed the backlog label Jul 9, 2018
@bess bess self-assigned this Jul 9, 2018
@bess bess added next and removed in progress labels Jul 10, 2018
@bess bess added future scope and removed backlog labels Aug 12, 2018
@little9 little9 self-assigned this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug future scope
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bess @no-reply @mark-dce @little9 @shanitajohn