When editing Committee Chair & Member - edited chair/member persists and new is added #1675
Comments
little9
added a commit
that referenced
this issue
Aug 18, 2018
The committee chairs/members aren't updating correctly. When updating an Etd this commit should remove any existing members/chairs and replace them with whatever is in your update submission. Before members/chairs where never being deleted but appended to on each update so you would have many duplicates. Whenever I run this code it seems like sometimes the update hasn't been indexed correctly because the members don't show up on show page, but are present on the `Etd` object. Connected to #1675 Connected to #1616
little9
added a commit
that referenced
this issue
Aug 18, 2018
The committee chairs/members aren't updating correctly. When updating an Etd this commit should remove any existing members/chairs and replace them with whatever is in your update submission. Before members/chairs where never being deleted but appended to on each update so you would have many duplicates. Whenever I run this code it seems like sometimes the update hasn't been indexed correctly because the members don't show up on show page, but are present on the `Etd` object. Connected to #1675 Connected to #1616
little9
added a commit
that referenced
this issue
Aug 18, 2018
The committee chairs/members aren't updating correctly. When updating an Etd this commit should remove any existing members/chairs and replace them with whatever is in your update submission. Before members/chairs where never being deleted but appended to on each update so you would have many duplicates. Whenever I run this code it seems like sometimes the update hasn't been indexed correctly because the members don't show up on show page, but are present on the `Etd` object. Connected to #1675 Connected to #1616
val99erie
added a commit
that referenced
this issue
Aug 21, 2018
I cleared the committee members and chairs before passing the new params from the form to the actor. I fixed the methods that keep the committee_chair_name and committee_members_names in sync with the committee_chair and committee_members fields.
|
The solution that I implemented works properly from the point-of-view of a student, but it leaves behind orphaned records in fedora. After discussion with the team, since we are so close to the deadline, we decided that this is acceptable for now. I wrote story #1733 to fix this problem in a future release. |
|
Was able to change and add committee chairs and members without unintended multiples showing. Tested on QA | 2017 Emory University. Version v2.0.0-beta8 updated 22 August 2018 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When editing Committee Chair & Member:
I edit the Name field and instead of replacing/changing that name- a new chair/member is added, so that I end up with multiple unintentional chairs/members. New ones added each time I try to edit.
Tested in QA | 2017 Emory University. Version master updated 17 August 2018
The text was updated successfully, but these errors were encountered: