Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not backport PRs closed ("merged") because of other PRs getting merged #42

Open
kmaehashi opened this issue Aug 7, 2024 · 0 comments

Comments

@kmaehashi
Copy link
Member

cupy/cupy#8460 (comment)

It seems that the backport tool does not cover this case: two PRs with to-be-backported label exist and one closed because of another one getting merged.

cupy/cupy#8221 automatically closed as "merged" because cupy/cupy#8412 got merged, which includes all commits from 8221.

This case can be detected by checking merged_by field from the pull-request API response. If it is null (like 8221), it indicates the PR was not merged but all commits in the PR got merged in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant