FilterBar: Use v3 Button+Menu for 'Add filters' #5330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougmacknz
force-pushed
the
dug/use-new-menu-for-add-filters
branch
from
e29ac98 to
c29449c
Compare
🦋 Changeset detectedLatest commit: b01c890 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougmacknz
force-pushed
the
dug/use-new-menu-for-add-filters
branch
3 times, most recently
from
4e85bbf to
76bc55c
Compare
|
putting in review for chromatic |
dougmacknz
force-pushed
the
dug/use-new-menu-for-add-filters
branch
from
76bc55c to
663cb58
Compare
dougmacknz
force-pushed
the
dug/use-new-menu-for-add-filters
branch
from
663cb58 to
b01c890
Compare
|
Closing for now, more investigation required on how we might want to adjust things to have the new button look better alongside the filter trigger buttons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Request PR reviews on Slack
Please reach out to the design system team on Slack in
#prod_design_systemfor PR reviews. GitHub notifications (e.g. from tagging a person) are not actively monitored.Why
What