Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit CCK download to make PHP acceptance tests run #135

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ciaranmcnulty
Copy link
Contributor

@ciaranmcnulty ciaranmcnulty commented Jan 6, 2023

Fixes #134

End to end tests were skipped because the path to CCK sample data was broken during extraction from the monorepo.

  • adds a separation between unit tests and the (one) end to end test
  • makes the end to end test fail loudly if the CCK samples aren't present
  • explicitly downloads the CCK samples from GitHub during the docker build

@luke-hill
Copy link
Contributor

@ciaranmcnulty - We're releasing a major version of the CCK (v13), soon.

95% of it is ruby breaking changes, but there is one global change (2x bugfixes to attachment).

If you want to follow it: Progress is here: cucumber/compatibility-kit#52

@luke-hill
Copy link
Contributor

I've had a thought about this recently, and wouldn't it be better to just have php conformance inside the CCK proper? You could even slowly introduce it for say 1 sample at a time if there are things which aren't quite right.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Jul 5, 2024

@luke-hill dependency wise that doesn't work. Using the cck to test messages creates a circular dependency. And testing specific implementation in the CCK is also something we don't want to do to keep the CCK simple.

Do keep in mind that this pull request is there to make sure tests are ran at all. It is not the perfect solution. The perfect solution would be to pare down the tests in messages just to the point where they test if serialization works. Because all messages are generated, a few well chosen tests can validate that all messages work.

So if possible, consider merging this as and then we can improve from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP version doesn't run end-to-end tests since monorepo split
3 participants