Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The release process has a dependency on shx #106

Open
mpkorstanje opened this issue Nov 14, 2022 · 0 comments
Open

The release process has a dependency on shx #106

mpkorstanje opened this issue Nov 14, 2022 · 0 comments

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Nov 14, 2022

🤔 What's the problem you've observed?

$ git clean -dfx # Important, otherwise node_modules may stick around
$ polyglot-release 20.0.0
sh: 1: shx: not found
npm ERR! code 127
npm ERR! path /home/mpkorstanje/Projects/cucumber/messages/javascript
npm ERR! command failed
npm ERR! command sh -c -- shx echo "// This file is automatically generated using npm scripts" > src/version.ts && echo "export const version = '${npm_package_version}'" >> src/version.ts

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/mpkorstanje/.npm/_logs/2022-11-14T14_19_39_663Z-debug-0.log

Because we invoke some shell scripts around the build:

"version": "shx echo \"// This file is automatically generated using npm scripts\" > src/version.ts && echo \"export const version = '${npm_package_version}'\" >> src/version.ts",

This requires either installing dev dependencies before releasing or installing shx globally.

✨ Do you have a proposal for making it better?

Either

  • remove the (need for) shell scripts;
  • or add a check for shx to polyglot-release

https://github.com/cucumber/polyglot-release/blob/fc50e6fdf3ab2f8af5f140064887667eab9785e7/polyglot-release#L125-L127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant